Various crews tackle wildfire spanning more than 12 acres in Braintree
UK.gov's nuclear strategy is 'slow, inefficient, and costly'
An independent taskforce commissioned by the UK government has warned of the nation's "unnecessarily slow, inefficient, and costly" approach to nuclear power (and weaponry).…
China records more cases of deadly chikungunya virus as country battles 'largest outbreak ever'
CCTV appeal after armed robbery at busy Southend railway station
Amazon's Starlink Competitor Tops 100 Satellites
Read more of this story at Slashdot.
The pretty Essex beach town that feels like going back in time named the 'sunniest in UK'
Meghan Markle and Prince Harry's new Netflix deal 'IS a downgrade' and more like a 'we'll call you' than 'here's the chequebook', experts say
Countries with the most 100-year-olds REVEALED - find out where Britain ranks in our league table
Sir Keir Starmer would not call shoplifters 'scumbags', No 10 says in the wake of 'data protection' saga
DC's liberal residents slam Trump for 'overstepping' with takeover of their city... but admit crime is rampant as troops prepare to flood streets
David and Victoria Beckham fear Brooklyn has 'quit the family' after failing to invite ANY of his relatives to vow renewal with Nicola Peltz - and his parents only found out after reading about it in the news
Princess Andre says she goes to her stepmum Emily for romantic advice after revealing the toll mum Katie's Price chaotic love life took on her
A&E waits fuel 4,000 attacks on NHS staff a year: One worker is attacked every two hours in 'tinder box' hospitals as nurses face violence and gun threats
Major retail chain with 115 stores across the country confirms more shops will close next month - as it announces sales to clear remaining stock
Designer found dead in boat at ritzy yacht club had recently gone through divorce
'Prince Harry should stop being the victim': Queen's press secretary urges 'impulsive' duke to 'write his own script' because people are 'tired' of how he thinks 'world is against him'
Max Verstappen and his stylish girlfriend Kelly Piquet step out in the Sardinian sunshine with their kids on family trip - after buying plot of land in Portugal
Terrifying moment lightning strike causes tower of flames in South Carolina as hurricane weather threatens US
Poisoned telemetry can turn AIOps into AI Oops, researchers show
Automating IT operations using AI may not be the best idea at the moment.…
CodeSOD: Round Strips
JavaScript is frequently surprising in terms of what functions it does not support. For example, while it has a Math.round function, that only rounds to the nearest integer, not an arbitrary precision. That's no big deal, of course, as if you wanted to round to, say, four decimal places, you could write something like: Math.floor(n * 10000) / 10000.
But in the absence of a built-in function to handle that means that many developers choose to reinvent the wheel. Ryan found this one.
function stripExtraNumbers(num) { //check if the number's already okay //assume a whole number is valid var n2 = num.toString(); if(n2.indexOf(".") == -1) { return num; } //if it has numbers after the decimal point, //limit the number of digits after the decimal point to 4 //we use parseFloat if strings are passed into the method if(typeof num == "string"){ num = parseFloat(num).toFixed(4); } else { num = num.toFixed(4); } //strip any extra zeros return parseFloat(num.toString().replace(/0*$/,"")); }We start by turning the number into a string and checking for a decimal point. If it doesn't have one, we've already rounded off, return the input. Now, we don't trust our input, so if the input was already a string, we'll parse it into a number. Once we know it's a number, we can call toFixed, which returns a string rounded off to the correct number of decimal points.
This is all very dumb. Just dumb. But it's the last line which gets really dumb.
toFixed returns a padded string, e.g. (10).toFixed(4) returns "10.0000". But this function doesn't want those trailing zeros, so they convert our string num into a string, then use a regex to replace all of the trailing zeros, and then parse it back into a float.
Which, of course, when storing the number as a number, we don't really care about trailing zeros. That's a formatting choice when we output it.
I'm always impressed by a code sample where every single line is wrong. It's like a little treat. In this case, it even gets me a sense of how it evolved from little snippets of misunderstood code. The regex to remove trailing zeros in some other place in this developer's experience led to degenerate cases where they had output like 10., so they also knew they needed to have the check at the top to see if the input had a fractional part. Which the only way they knew to do that was by looking for a . in a string (have fun internationalizing that!). They also clearly don't have a good grasp on types, so it makes sense that they have the extra string check, just to be on the safe side (though it's worth noting that parseFloat is perfectly happy to run on a value that's already a float).
This all could be a one-liner, or maybe two if you really need to verify your types. Yet here we are, with a delightfully wrong way to do everything.
.comment { border: none; }