Aggregator

The mix-up at a Sydney childcare centre was only discovered when the toddler's mother arrived at the daycare to pick him up.

David G saw a pull request with a surprisingly long thread of comments on it. What was weirder was that the associated ticket was all about adding a single parameter to an existing method. What could be generating that much discussion?

How could adding an argument add to an argument?

registerFooWrapper: function(arg1, arg2, arg3, arg4, arg5, arg6, arg7) { bar.when('bar-event', function(context) { context.foo({ arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7, }); }); }

This is the original version of the JavaScript function. The parameter names have been anonymized. That aside, this still isn't very good. Seven parameters is likely too many, and based on what I see in setting the context, there is an object type that holds them all, so maybe we should be passing the object around in the first place? Still, this isn't a WTF by any stretch, and since it's already deployed code, changing the interface significantly is a bad idea- maybe just adding a parameter is the right choice here. So what generated so much discussion?

This revision:

registerFooWrapper: function(arg1, arg2, arg3, arg4, arg5, arg6, arg7, notArg8) { if (notArg8 === true) { bar.when('bar-event', function(context) { context.foo({ arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7, arg8: !notArg8, }); }); } else { bar.when('bar-event', function(context) { context.foo({ arg1: arg1, arg2: arg2, arg3: arg3, arg4: arg4, arg5: arg5, arg6: arg6, arg7: arg7 }); }); } }

Okay, so if notArg8 is true, we pass false to the context. If it's any other value, we don't past arg8 at all. I do not understand what I'm looking at here. If the goal is to ensure that arg8 is either true or not set, there are clearer ways to express that idea. But also, the goal of the ticket was not to do that- it was simply to add another parameter, which means you could drop the condition entirely and just add the parameter. context was already receiving arg8 as undefined, so it could clearly handle an undefined value.

David made some comments on the pull request, but the original developer just ended up going radio silent on it. One of the juniors on David's team approved it, for some reason, but nobody ever actually hit merge. Instead, a different developer simply made a version that took arg8 as a parameter, passed it down to context, and called it a day. It worked, the tests passed, and everyone was happy.

Well, except the original developer, but again, who knows what they were trying to do?

[Advertisement] ProGet’s got you covered with security and access controls on your NuGet feeds. Learn more.

Witnesses shared footage of a man escaping from his car as swooped on the High Road in North Finchley at about 12noon on Tuesday.

The House Oversight Committee has released a massive trove of Justice Department files on Jeffrey Epstein, the same day lawmakers pushed a bill to force out the documents.

Follow Daily Mail's live coverage here.

Residents in Tyldesley, Wigan, branded the colossal steel frames 'monstrous' as they became the latest structures at a 350,000 sq ft industrial site.

He was written off by history as a playboy with a fatal taste for martinis and morphine. But the Daily Mail can reveal there was an astonishing other side to the late Queen's uncle, the Duke of Kent.

A Kentucky college cheerleader appeared in court after she was charged with concealing the birth of her own baby, who was found dead in a garbage bag.

The bus is crucial for many people living in the smaller villages

‘Universities are being used to proxy offensive government operations, turning research access decisions political’

Censys Inc, vendor of the popular Censys internet-mapping tool, has revealed that state-based actors are trying to abuse its services by hiding behind academic researchers.…

Worried residents fear it will cause 'mayhem' 'on a major very busy road'

The science teacher at an Essex school admitted to using adult chat sites and looking at adult content while teaching students

Kim Kardashian shared an unorthodox parenting opinion. The reality star, 44, revealed that she 'doesn't believe in' homework for her four kids.

Cardi B has been cleared of assault after she was sued for $24million over an alleged 2018 altercation.

For those who get carsick, there's nothing worse. Now, a study into the issue has revealed a surprisingly simple solution that can slash symptoms in half.

A planning appeal for Pauls Farm in Little Bardfield has been dismissed due to concerns over noise.

Locals are campaigning against plans for new homes after flooding and sewage issues in the village

The 56-year-old Friends actress, who is known for her age-defying looks and toned frame, opened up about her beauty regime in a candid new interview.

From Moscow suburbs to windswept Siberia, a trickle of westerners have arrived, waving Bibles and clutching dreams of raising their children in a fortress of Christian order.

It’s been to space. It likely won’t launch India as a semiconductor superpower

India’s government yesterday celebrated an “important milestone” in the development of its semiconductor industry, and therefore the nation’s ambition to become a global contender, but the celebrations seem premature because the chip that was the star of the show is nothing special.…