Aggregator

Experts believe that a cocktail of good skincare, shiny, well-maintained hair and a glamorous wardrobe has taken years off Basingstoke-born actress Elizabeth Hurley's appearance.

The agreement means Britons travelling to the peninsula could be refused entry by Spanish guards enforcing the EU rules - despite it being a British Overseas Territory.

Harvey Weinstein's jury has returned a verdict in his New York sexual assault retrial.

Around a dozen yobs torched Larne Leisure Centre in County Antrim, which is believed to have taken in Romanian immigrants to shield them from this week's riots.

The garden has been badly affected by 'slippage' meaning it has lost many of its historic structures

Welcome to NEOM - a $500 billion mega-project the size of Belgium that, despite still being under construction, is already attracting a growing wave of expats from across the UK.

Confusingly, the magnetic north and south poles are both down there, where the Solar Orbiter can see them

Occupants of planet Earth can’t see the Sun’s poles – unless they look at images the Solar Orbiter spacecraft has just sent home.…

Dan's co-workers like passing around TDWTF stories, mostly because seeing code worse than what they're writing makes them feel less bad about how often they end up hacking things together.

One day, a co-worker told Dan: "Hey, I think I found something for that website with the bad code stories!"

Dan's heart sank. He didn't really want to shame any of his co-workers. Fortunately, the source-control history put the blame squarely on someone who didn't work there any more, so he felt better about submitting it.

This is another ASP .Net page, and this one made heavy use of GridView elements. GridView controls applied the logic of UI controls to generating a table. They had a page which contained six of these controls, defined like this:

<asp:GridView ID="gvTaskMonth1" runat="server" CssClass="leadsGridView" AutoGenerateColumns="False" OnRowDataBound="gvTaskMonth1_RowDataBound"> ... </asp:GridView> <asp:GridView ID="gvTaskMonth2" runat="server" CssClass="leadsGridView" AutoGenerateColumns="False" OnRowDataBound="gvTaskMonth1_RowDataBound"> ... </asp:GridView> <asp:GridView ID="gvTaskMonth3" runat="server" CssClass="leadsGridView" AutoGenerateColumns="False" OnRowDataBound="gvTaskMonth1_RowDataBound"> ... </asp:GridView>

The purpose of this screen was to display a roadmap of coming tasks, broken up by how many months in the future they were. The first thing that leaps out to me is that they all use the same event handler for binding data to the table, which isn't in-and-of-itself a problem, but the naming of it is certainly a recipe for confusion.

Now, to bind these controls to the data, there needed to be some code in the code-behind of this view which handled that. That's where the WTF lurks:

/// <summary> /// Create a roadmap for the selected client /// </summary> private void CreateRoadmap() { for (int i = 1; i < 7; i++) { switch (i) { case 1: if (gvTaskMonth1.Rows.Count > 0) { InsertTasks(gvTaskMonth1, DateTime.Parse(txtDatePeriod1.Text), "1"); } break; case 2: if (gvTaskMonth2.Rows.Count > 0) { InsertTasks(gvTaskMonth2, DateTime.Parse(txtDatePeriod2.Text), "2"); } break; case 3: if (gvTaskMonth3.Rows.Count > 0) { InsertTasks(gvTaskMonth3, DateTime.Parse(txtDatePeriod3.Text), "3"); } break; case 4: if (gvTaskMonth4.Rows.Count > 0) { InsertTasks(gvTaskMonth4, DateTime.Parse(txtDatePeriod4.Text), "4"); } break; case 5: if (gvTaskMonth5.Rows.Count > 0) { InsertTasks(gvTaskMonth5, DateTime.Parse(txtDatePeriod5.Text), "5"); } break; case 6: if (gvTaskMonth6.Rows.Count > 0) { InsertTasks(gvTaskMonth6, DateTime.Parse(txtDatePeriod6.Text), "6"); } break; } } }

Ah, the good old fashioned loop-switch sequence anti-pattern. I understand the motivation: "I want to do the same thing for six different controls, so I should use a loop to not repeat myself," but then couldn't quite figure out how to do that, so they just repeated themselves, but inside of a loop.

The "fix" was to replace all of this with something more compact:

private void CreateRoadmap() { InsertTasks(gvTaskMonth1, DateTime.Parse(txtDatePeriod1.Text), "1"); InsertTasks(gvTaskMonth2, DateTime.Parse(txtDatePeriod2.Text), "2"); InsertTasks(gvTaskMonth3, DateTime.Parse(txtDatePeriod3.Text), "3"); InsertTasks(gvTaskMonth4, DateTime.Parse(txtDatePeriod4.Text), "4"); InsertTasks(gvTaskMonth5, DateTime.Parse(txtDatePeriod5.Text), "5"); InsertTasks(gvTaskMonth6, DateTime.Parse(txtDatePeriod6.Text), "6"); }

That said, I'd recommend not trying to parse date times inside of a text box inside of this method, but that's just me. Bubbling up the inevitable FormatException that this will generate is going to be a giant nuisance. It's likely that they've got a validator somewhere, so it's probably fine- I just don't like it.

.comment { border: none; } [Advertisement] Keep the plebs out of prod. Restrict NuGet feed privileges with ProGet. Learn more.

The Home Office's total budget will be decreased but core spending by the police is planned to rise

Flying business class is a luxury that takes the stress right out of travelling, but it obviously comes at a greater cost than economy. Here are top tips to ensure you get your money's worth,

The cafe was given six months to remove the signs after they were installed without permission

Chancellor Rachel Reeves has unveiled a Government spending spree on Britain's schools, hospitals and armed forces as critics immediately questioned how she would pay for it.

He had already been banned from abusing people, but was reportedly escorting people to cash points to ensure they withdrew money for him

The bra tycoon had recommended PPE Medpro, which went on to provide 25 million 'faulty' surgical gowns.

Two experts outline nine key red flags to watch out for before taking the plunge and buying a home.

Building AMD computational cancer research super and ICL workhorse with Intel inside

Lenovo has pulled a couple of European supercomputer wins out of the bag, one using Intel chips for Imperial College London and an AMD-based system for the European Institute of Oncology.…

Britney Spear's relationship with her son Jayden has left those close to her worried over his intentions, as the singer continues to shower the teen with gifts.

Virginia McCullough's story is one of violence, deception and a web of lies that eventually unravelled

Charles 'Tex' Watson grew up in small-town Texas, seemingly destined to be an all-American success story. Then, a visit to California in 1967 changed his life - and American criminal history.

A mysterious geological formation perched high in the mountains of Turkey could be the site where Noah's Ark landed around 4,300 years ago.